Skip to content

Added Tokenizer and Filters querystring param to Analyze request #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2013
Merged

Added Tokenizer and Filters querystring param to Analyze request #284

merged 1 commit into from
Jun 12, 2013

Conversation

michielpost
Copy link
Contributor

Params were missing

@Mpdreamz
Copy link
Member

Hey @michielpost thanks!

quick question do we really need the elseifs here? Might just as well allow all combinations?

I say this having not looked at the ES docs :)

@michielpost
Copy link
Contributor Author

The original if/else if was already there.
If the Field param is filled, don't send the Analyzer, because it will be ignored by ES.

For consistency I added the second else. The Filters and Tokenizer params will be ignored if you send the Analyzer or Field params.

Mpdreamz added a commit that referenced this pull request Jun 12, 2013
Added Tokenizer and Filters querystring param to Analyze request
@Mpdreamz Mpdreamz merged commit 179e448 into elastic:master Jun 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants